liukun4515 commented on issue #2637: URL: https://github.com/apache/arrow-rs/issues/2637#issuecomment-1241409983
> In arrow2, Decimal128 is based on `PrimitiveArray<i128>`, maybe we could learn from it. (I am not 100% sure, but in arrow2 Decimal seems like a logical type (a combination of `PrimitiveArray` and `DataType::Decimal`).) [jorgecarleitao/arrow2#1194](https://github.com/jorgecarleitao/arrow2/pull/1194) use `i128` to represent the decimal128 is good way which is used in current kernel computing. i128 can be compared and do arithmetic op easily, but it's not a generic way if we need to support decimal256. Do you have any thoughts about this @viirya ? I know you implement the most feature about decimal256 and refactor some part of decimal. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
