kou commented on code in PR #13991:
URL: https://github.com/apache/arrow/pull/13991#discussion_r966576816
##########
cpp/src/gandiva/CMakeLists.txt:
##########
@@ -27,16 +27,7 @@ add_dependencies(gandiva-all gandiva gandiva-tests
gandiva-benchmarks)
find_package(LLVMAlt REQUIRED)
-if(LLVM_VERSION_MAJOR LESS "10")
- set(GANDIVA_CXX_STANDARD ${CMAKE_CXX_STANDARD})
-else()
- # LLVM 10 or later requires C++ 14
- if(CMAKE_CXX_STANDARD LESS 14)
- set(GANDIVA_CXX_STANDARD 14)
- else()
- set(GANDIVA_CXX_STANDARD ${CMAKE_CXX_STANDARD})
- endif()
-endif()
+set(GANDIVA_CXX_STANDARD ${CMAKE_CXX_STANDARD})
Review Comment:
How about removing `GANDIVA_CXX_STANDARD` and using `CMAKE_CXX_STANDARD`
directly?
##########
.github/workflows/r.yml:
##########
@@ -119,12 +119,13 @@ jobs:
fail-fast: false
matrix:
config:
- - { org: "rstudio", image: "r-base", tag: "4.0-centos7" }
- - { org: "rhub", image: "debian-gcc-devel", tag: "latest" }
+ - { org: "rstudio", image: "r-base", tag: "4.0-centos7", devtoolset:
"8" }
+ - { org: "rhub", image: "debian-gcc-devel", tag: "latest",
devtoolset: "-1" }
Review Comment:
How about using an empty instead of `-1`?
```suggestion
- { org: "rhub", image: "debian-gcc-devel", tag: "latest",
devtoolset: "" }
```
We can detect it in shell script with the following:
```shell
if [[ -n "$DEVTOOLSET_VERSION" ]]; then
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
