zhztheplayer commented on code in PR #13249:
URL: https://github.com/apache/arrow/pull/13249#discussion_r966727267
##########
java/c/src/main/java/org/apache/arrow/c/ArrayImporter.java:
##########
@@ -143,7 +143,9 @@ private List<ArrowBuf> importBuffers(ArrowArray.Snapshot
snapshot) {
if (bufferPtr != NULL) {
// TODO(roee88): an API for getting the size for each buffer is not yet
// available
- buffer = new ArrowBuf(referenceManager, null, Integer.MAX_VALUE,
bufferPtr);
+ int length = Integer.MAX_VALUE;
Review Comment:
We have been using different terms everywhere for this field including size,
length, capacity, etc. For this PR I think it's enough to just rename 'length'
to 'capacity' in `ArrowBuf` class? 'length' and 'size' may still be intuitive
to users when it comes to buffer allocation and buffer slicing or other use
cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
