tustvold commented on code in PR #2680:
URL: https://github.com/apache/arrow-rs/pull/2680#discussion_r966744083
##########
arrow/src/compute/kernels/sort.rs:
##########
@@ -514,12 +539,40 @@ where
.map(|index| (index, values.value(index as usize)))
.collect::<Vec<(u32, T::Native)>>()
};
- sort_primitive_inner(values, null_indices, cmp, options, limit, valids)
+ sort_primitive_inner(values.len(), null_indices, cmp, options, limit,
valids)
+}
+
+/// Sort dictionary encoded primitive values
+fn sort_primitive_dictionary<K, F>(
+ values: &DictionaryArray<K>,
+ sorted_value_indices: &UInt32Array,
+ value_indices: Vec<u32>,
+ null_indices: Vec<u32>,
+ options: &SortOptions,
Review Comment:
FWIW `&SortOptions` is actually bigger than `SortOptions`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
