lidavidm commented on code in PR #14085:
URL: https://github.com/apache/arrow/pull/14085#discussion_r967259583
##########
cpp/src/arrow/dataset/file_base.cc:
##########
@@ -93,8 +93,11 @@ bool FileSource::Equals(const FileSource& other) const {
bool match_file_system =
(filesystem_ == nullptr && other.filesystem_ == nullptr) ||
(filesystem_ && other.filesystem_ &&
filesystem_->Equals(other.filesystem_));
- return match_file_system && file_info_.Equals(other.file_info_) &&
- buffer_->Equals(*other.buffer_) && compression_ == other.compression_;
+ bool match_buffer = (buffer_ == nullptr && other.buffer_ == nullptr) ||
+ ((buffer_ != nullptr && other.buffer_ != nullptr) &&
+ (buffer_->address() == other.buffer_->address()));
Review Comment:
Hmm, so we deliberately want identity instead of value equality here? I
guess comparing the contents is expensive? (When are we comparing FileSources
anyways?)
##########
cpp/src/arrow/dataset/file_base.cc:
##########
@@ -93,8 +93,11 @@ bool FileSource::Equals(const FileSource& other) const {
bool match_file_system =
(filesystem_ == nullptr && other.filesystem_ == nullptr) ||
(filesystem_ && other.filesystem_ &&
filesystem_->Equals(other.filesystem_));
- return match_file_system && file_info_.Equals(other.file_info_) &&
- buffer_->Equals(*other.buffer_) && compression_ == other.compression_;
+ bool match_buffer = (buffer_ == nullptr && other.buffer_ == nullptr) ||
+ ((buffer_ != nullptr && other.buffer_ != nullptr) &&
+ (buffer_->address() == other.buffer_->address()));
+ return match_file_system && file_info_.Equals(other.file_info_) &&
match_buffer &&
Review Comment:
nit: move match_buffer earlier so as to short-circuit earlier?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
