datapythonista opened a new pull request, #2699:
URL: https://github.com/apache/arrow-rs/pull/2699
# Which issue does this PR close?
None
# Rationale for this change
When reading the docs for the `with_capacity` method of
`GenericBinaryBuilder` and `GenericStringBuilder` it gave me the impression
that since `item_capacity` is specified, `data_capacity` could be the number of
bytes per string or item, not the total data to pre-allocate. For someone who
understands the internal details of how a string array is stored this may be
quite obvious, but for someone new who is reading this after the
`with_capacity` of for example an int type, I think it's confusing.
# What changes are included in this PR?
I updated the docs to clarify the above, and avoid ambiguity and anything
that can mislead. Also made some related minor changes for consistency, like
specifying that the `append_` methods of the builder append to the builder
instead of the array (kind of the same, but having both mixed feels confusing).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
