dhruv9vats commented on code in PR #14059:
URL: https://github.com/apache/arrow/pull/14059#discussion_r967832304
##########
cpp/src/arrow/ArrowConfig.cmake.in:
##########
@@ -172,3 +172,16 @@ endmacro()
arrow_keep_backward_compatibility(Arrow arrow)
check_required_components(Arrow)
+
+function(arrow_show_details PACKAGE_NAME)
+ if(NOT ${PACKAGE_NAME}_FIND_QUIETLY)
+ string(TOUPPER ${PACKAGE_NAME} package_name_upper)
+ message(STATUS "${PACKAGE_NAME} version: ${${package_name_upper}_VERSION}")
+ message(STATUS "Found the ${PACKAGE_NAME} shared library:
${${package_name_upper}_SHARED_LIB}")
Review Comment:
The signature now is `macro(arrow_show_details package_name
variable_prefix)`, but does it make sense to use `target_base_name` instead of
`variable_prefix` as `arrow_keep_backward_compatibility`, and do something like:
```
macro(arrow_show_details package_name target_base_name)
string(TOUPPER ${target_base_name} target_base_name_upper)
.
.
.
endmacro()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
