Dandandan commented on code in PR #3444:
URL: https://github.com/apache/arrow-datafusion/pull/3444#discussion_r967863267
##########
datafusion/optimizer/src/type_coercion.rs:
##########
@@ -64,7 +66,15 @@ impl OptimizerRule for TypeCoercion {
_ => DFSchemaRef::new(DFSchema::empty()),
};
- let mut expr_rewrite = TypeCoercionRewriter { schema };
+ let mut execution_props = ExecutionProps::new();
+ execution_props.query_execution_start_time =
+ optimizer_config.query_execution_start_time;
+ let const_evaluator = ConstEvaluator::try_new(&execution_props)?;
Review Comment:
A useful suggestion, but I couldn't find a way to do this given the current
trait/method signatures and making the borrow checker happy.
Given that in the expression simplifier pass one is instantiated per
expression (instead of per plan), I guess this should be ok enough?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
