HaoYang670 commented on code in PR #3398:
URL: https://github.com/apache/arrow-datafusion/pull/3398#discussion_r967958710
##########
datafusion/common/src/scalar.rs:
##########
@@ -2575,7 +2575,7 @@ mod tests {
// The alignment requirements differ across architectures and
// thus the size of the enum appears to as as well
- let expected = match cfg!(target_arch = "aarch64") {
+ let expected = match cfg!(target_arch = "x86_64") {
true => 64,
false => 48,
Review Comment:
These 4 values seem to occupy largest memory
```rust
TimestampSecond(Option<i64>, Option<String>), // 8 + 16 + 24
/// Timestamp Milliseconds
TimestampMillisecond(Option<i64>, Option<String>),
/// Timestamp Microseconds
TimestampMicrosecond(Option<i64>, Option<String>),
/// Timestamp Nanoseconds
TimestampNanosecond(Option<i64>, Option<String>),
```
The payload occupies 48 bytes and the tag occupies 1 byte (but this could be
represented by niche?). So the overall size of the Enum if 48 I guess.
##########
datafusion/common/src/scalar.rs:
##########
@@ -2575,7 +2575,7 @@ mod tests {
// The alignment requirements differ across architectures and
// thus the size of the enum appears to as as well
- let expected = match cfg!(target_arch = "aarch64") {
+ let expected = match cfg!(target_arch = "x86_64") {
true => 64,
false => 48,
Review Comment:
These 4 values seem to occupy largest memory
```rust
TimestampSecond(Option<i64>, Option<String>), // 8 + 16 + 24
/// Timestamp Milliseconds
TimestampMillisecond(Option<i64>, Option<String>),
/// Timestamp Microseconds
TimestampMicrosecond(Option<i64>, Option<String>),
/// Timestamp Nanoseconds
TimestampNanosecond(Option<i64>, Option<String>),
```
The payload occupies 48 bytes and the tag occupies 1 byte (but this could be
represented by niche?). So the overall size of the Enum is 48 I guess.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
