carols10cents commented on pull request #8291: URL: https://github.com/apache/arrow/pull/8291#issuecomment-701609481
Oops, I... thought I knew what I was doing a little bit, and I clearly don't at all 😅 I think I went down this path because rust/parquet/src/arrow/schema.rs had the commented-out dictionary field [that was added to this branch](https://github.com/apache/arrow/compare/rust-parquet-arrow-writer#diff-b1d078f4cb4841c220e8a274543ef616R1399) in this test: ``` #[test] fn test_arrow_schema_roundtrip() -> Result<()> { // This tests the roundtrip of an Arrow schema // Fields that are commented out fail roundtrip tests or are unsupported by the writer ``` and I thought "the writer" in this comment and exercised by this test meant the Arrow -> Parquet writer. But it's the changes in rust/arrow/src/ipc/convert.rs that get this test to pass, so I'm not sure where I got turned around... Am I at least correct that adding dictionary support will involve adding support for the dictionary schema as well as the dictionary data? And that neither of those are done yet? I'm also unclear about what I should do with this PR based on your comment; should I close it for now or fix the signed index type issue and reopen it against master? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
