kmitchener commented on PR #3447: URL: https://github.com/apache/arrow-datafusion/pull/3447#issuecomment-1243891031
> Looks good @kmitchener 👍 thank you > > Looking at this code, I wonder why there are special cases for Expr values at all in the sql planner. It seems like this is a special case of expression coercion (aka we are trying to coerce / cast all arguments to the same type). Hmm, do you mean that maybe we can set some rules about which exprs are valid and use those to filter the input to values() rather than explicitly listing which expressions are valid? It does seem like there should be a better way to do this, because values() can take most (any?) expression that's not aggregate, like substring or case or even try_cast for that matter .. maybe a follow-on issue for that? that's beyond me at the moment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
