pacman82 opened a new issue, #2708:
URL: https://github.com/apache/arrow-rs/issues/2708

   **Is your feature request related to a problem or challenge? Please describe 
what you are trying to do.**
   <!--
   A clear and concise description of what the problem is. Ex. I'm always 
frustrated when [...] 
   (This section helps Arrow developers understand the context and *why* for 
this feature, in addition to  the *what*)
   -->
   Maintaimer of the downstream `odbc2parquet` tool here. I would like to 
switch from converted type to logical types. One bump in the road of doing so 
is the fact that `odbc2parquet` now directly needs to depend also on the 
`parquet-format` crate instead of just `parquet`. The cause being, that it is 
impossible to create an instance of `TimeUnit` for the logical type, due to it 
being depended on e.g. `MilliSeconds` or `MicroSeconds` type of the 
`parquet-format` crate.
   
   **Describe the solution you'd like**
   <!--
   A clear and concise description of what you want to happen.
   -->
   I think I do not fully grasp why the current design has been choosen, so I 
am not particularly biased towards any solution. I could brainstorm a few ideas 
though:
   
   * Drop the `MilliSeconds` type tag from the `TimeUnit::MILLIS` variant.
   * Give `TimeUnit` constructors for milliseconds, microseconds, etc.
   * Reexport `MilliSeconds`, `MicroSeconds`, etc. ..
   
   
   **Describe alternatives you've considered**
   <!--
   A clear and concise description of any alternative solutions or features 
you've considered.
   -->
   Currently I'll just add the extra **direct** dependency to `parquet-format`. 
If this is what you want me to do, consider this issue void.
   **Additional context**
   <!--
   Add any other context or screenshots about the feature request here.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to