cyb70289 commented on code in PR #14098:
URL: https://github.com/apache/arrow/pull/14098#discussion_r969107632
##########
go/arrow/compute/internal/kernels/helpers.go:
##########
@@ -513,3 +514,134 @@ func (v *validityBuilder) Finish() (buf *memory.Buffer) {
v.buffer = nil
return
}
+
+type execBufBuilder struct {
+ mem memory.Allocator
+ buffer *memory.Buffer
+ data []byte
+ sz int
+}
+
+func (bldr *execBufBuilder) resize(newcap int) {
+ if bldr.buffer == nil {
+ bldr.buffer = memory.NewResizableBuffer(bldr.mem)
+ }
+
+ bldr.buffer.ResizeNoShrink(newcap)
+ bldr.data = bldr.buffer.Bytes()
+}
+
+func (bldr *execBufBuilder) reserve(additional int) {
+ if bldr.buffer == nil {
+ bldr.buffer = memory.NewResizableBuffer(bldr.mem)
+ }
+
+ mincap := bldr.sz + additional
+ if mincap <= cap(bldr.data) {
+ return
+ }
+ bldr.buffer.ResizeNoShrink(mincap)
+ bldr.data = bldr.buffer.Buf()
+}
+
+func (bldr *execBufBuilder) unsafeAppend(data []byte) {
+ copy(bldr.data[bldr.sz:], data)
+ bldr.sz += len(data)
+}
+
+func (bldr *execBufBuilder) unsafeAppendN(n int, val byte) {
+ bldr.data[bldr.sz] = val
+ for i := 1; i < n; i *= 2 {
+ copy(bldr.data[bldr.sz+i:], bldr.data[bldr.sz:bldr.sz+i])
+ }
Review Comment:
Is the capacity of `bldr.data` always rounded up to power of 2?
Otherwise, looks this code may cause buffer overflow. E.g., it appends 4
bytes is `n = 3`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
