tustvold commented on issue #3410: URL: https://github.com/apache/arrow-datafusion/issues/3410#issuecomment-1245420729
> If we add such info to TaskContext, errors can be propagated easily and there is less burden to the programer. Calling tokio::spawn without doing anything with the join handle is not a good idea, not only will you potentially silently drop errors, as you elude to, but more problematically you will miss panics. This has been a frequent pain point, see the work by @crepererum to fix this https://github.com/apache/arrow-datafusion/pulls?q=is%3Apr+is%3Aclosed+author%3Acrepererum. Longer term I'm hoping to move away from tokio see https://github.com/apache/arrow-datafusion/issues/2504, in part to do away with these types of problems, but I'm not sure when I'll get back to working on that. In the meantime, a tokio::spawn that doesn't stash the JoinHandle is an anti-pattern IMO. > additional improvements to errors / error handling If we are to go down this route, I think the question to ask is "what users are there of the current structured error handling". In particular, could we just use something like [anyhow](https://docs.rs/anyhow/latest/anyhow/) which we already have a transitive dependency on as a result of prost... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
