kou commented on code in PR #14105:
URL: https://github.com/apache/arrow/pull/14105#discussion_r969656023
##########
.github/workflows/cpp.yml:
##########
@@ -271,8 +271,8 @@ jobs:
uses: actions/cache@v2
with:
path: ${{ steps.ccache-info.outputs.cache-dir }}
- key: cpp-ccache-windows-${{ hashFiles('cpp/**') }}
- restore-keys: cpp-ccache-windows-
+ key: cpp-ccache-windows-v2-${{ hashFiles('cpp/**') }}
+ restore-keys: cpp-ccache-windows-v2-
Review Comment:
https://github.com/apache/arrow/actions/runs/3043600576/jobs/4905543765#step:11:1405
?
```text
FAILED: debug/arrow-public-api-test.exe
cmd.exe /C "cd . && "C:\Program Files\CMake\bin\cmake.exe" -E vs_link_exe
--intdir=src\arrow\CMakeFiles\arrow-public-api-test.dir
--rc=C:\PROGRA~2\WI3CF2~1\10\bin\100226~1.0\x64\rc.exe
--mt=C:\PROGRA~2\WI3CF2~1\10\bin\100226~1.0\x64\mt.exe --manifests --
C:\PROGRA~2\MICROS~1\2019\ENTERP~1\VC\Tools\MSVC\1429~1.301\bin\Hostx64\x64\link.exe
/nologo src\arrow\CMakeFiles\arrow-public-api-test.dir\public_api_test.cc.obj
/out:debug\arrow-public-api-test.exe /implib:debug\arrow-public-api-test.lib
/pdb:debug\arrow-public-api-test.pdb /version:0.0 /machine:x64
/NODEFAULTLIB:LIBCMT /debug /INCREMENTAL /subsystem:console
debug\arrow_testing.lib debug\arrow.lib "C:\Program
Files\OpenSSL-Win64\lib\VC\libcrypto64MDd.lib" "C:\Program
Files\OpenSSL-Win64\lib\VC\libssl64MDd.lib"
utf8proc_ep-install\lib\utf8proc_static.lib re2_ep-install\lib\re2.lib
googletest_ep-prefix\lib\gtest_maind.lib googletest_ep-prefix\lib\gtestd.lib
googletest_ep-prefix\lib\gmockd.lib "C:\Program Files\OpenSSL
-Win64\lib\VC\libcrypto64MDd.lib"
mimalloc_ep\src\mimalloc_ep\lib\mimalloc-2.0\mimalloc-static-debug.lib
bcrypt.lib psapi.lib ws2_32.lib kernel32.lib user32.lib gdi32.lib
winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib
advapi32.lib && cd ."
LINK Pass 1: command
"C:\PROGRA~2\MICROS~1\2019\ENTERP~1\VC\Tools\MSVC\1429~1.301\bin\Hostx64\x64\link.exe
/nologo src\arrow\CMakeFiles\arrow-public-api-test.dir\public_api_test.cc.obj
/out:debug\arrow-public-api-test.exe /implib:debug\arrow-public-api-test.lib
/pdb:debug\arrow-public-api-test.pdb /version:0.0 /machine:x64
/NODEFAULTLIB:LIBCMT /debug /INCREMENTAL /subsystem:console
debug\arrow_testing.lib debug\arrow.lib C:\Program
Files\OpenSSL-Win64\lib\VC\libcrypto64MDd.lib C:\Program
Files\OpenSSL-Win64\lib\VC\libssl64MDd.lib
utf8proc_ep-install\lib\utf8proc_static.lib re2_ep-install\lib\re2.lib
googletest_ep-prefix\lib\gtest_maind.lib googletest_ep-prefix\lib\gtestd.lib
googletest_ep-prefix\lib\gmockd.lib C:\Program
Files\OpenSSL-Win64\lib\VC\libcrypto64MDd.lib
mimalloc_ep\src\mimalloc_ep\lib\mimalloc-2.0\mimalloc-static-debug.lib
bcrypt.lib psapi.lib ws2_32.lib kernel32.lib user32.lib gdi32.lib winspool.lib
shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.li
b /MANIFEST
/MANIFESTFILE:src\arrow\CMakeFiles\arrow-public-api-test.dir/intermediate.manifest
src\arrow\CMakeFiles\arrow-public-api-test.dir/manifest.res" failed (exit code
1120) with the following output:
public_api_test.cc.obj : error LNK2019: unresolved external symbol
"__declspec(dllimport) class std::optional<class std::basic_string<char,struct
std::char_traits<char>,class std::allocator<char> > > __cdecl
arrow::GetTestTimezoneDatabaseRoot(void)"
(__imp_?GetTestTimezoneDatabaseRoot@arrow@@YA?AV?$optional@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@std@@XZ)
referenced in function "private: virtual void __cdecl
arrow::Misc_SetTimezoneConfig_Test::TestBody(void)"
(?TestBody@Misc_SetTimezoneConfig_Test@arrow@@EEAAXXZ)
debug\arrow-public-api-test.exe : fatal error LNK1120: 1 unresolved externals
```
I agree with you.
How about the following for easy to understand this?
```diff
diff --git a/.github/workflows/cpp.yml b/.github/workflows/cpp.yml
index d4c5c4c897..4b35e8365f 100644
--- a/.github/workflows/cpp.yml
+++ b/.github/workflows/cpp.yml
@@ -271,8 +271,11 @@ jobs:
uses: actions/cache@v2
with:
path: ${{ steps.ccache-info.outputs.cache-dir }}
- key: cpp-ccache-windows-${{ hashFiles('cpp/**') }}
- restore-keys: cpp-ccache-windows-
+ key: cpp-ccache-windows-${{ env.CACHE_VERSION }}-${{
hashFiles('cpp/**') }}
+ restore-keys: cpp-ccache-windows-${{ env.CACHE_VERSION }}-
+ env:
+ # We can invalidate the current cache by updating this.
+ CACHE_VERSION: "2022-09-13"
- name: Build
shell: cmd
run: |
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
