alamb commented on code in PR #3455:
URL: https://github.com/apache/arrow-datafusion/pull/3455#discussion_r970079294
##########
datafusion/core/src/catalog/information_schema.rs:
##########
@@ -39,26 +41,32 @@ use super::{
schema::SchemaProvider,
};
+use crate::config::ConfigOptions;
+
const INFORMATION_SCHEMA: &str = "information_schema";
const TABLES: &str = "tables";
const VIEWS: &str = "views";
const COLUMNS: &str = "columns";
+const SETTINGS: &str = "settings";
Review Comment:
> df_settings sounds good. should we leave it in information_schema, or move
it out?
I don't have any preference -- whatever is easier at first
(`information_schema` seems reasonable to me(
##########
datafusion/core/src/catalog/information_schema.rs:
##########
@@ -39,26 +41,32 @@ use super::{
schema::SchemaProvider,
};
+use crate::config::ConfigOptions;
+
const INFORMATION_SCHEMA: &str = "information_schema";
const TABLES: &str = "tables";
const VIEWS: &str = "views";
const COLUMNS: &str = "columns";
+const SETTINGS: &str = "settings";
Review Comment:
> df_settings sounds good. should we leave it in information_schema, or move
it out?
I don't have any preference -- whatever is easier at first
(`information_schema` seems reasonable to me)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
