jorisvandenbossche commented on code in PR #14096: URL: https://github.com/apache/arrow/pull/14096#discussion_r970548303
########## python/pyarrow/parquet/core.py: ########## @@ -16,23 +16,22 @@ # under the License. -from collections import defaultdict -from concurrent import futures -from contextlib import nullcontext -from functools import partial, reduce - -import sys -import json -from collections.abc import Collection -import numpy as np -import os -import re -import operator -import urllib.parse -import warnings - -import pyarrow as pa -import pyarrow.lib as lib +from collections import defaultdict as _defaultdict Review Comment: Is there a reason to rename those? I thought that if `__all__` is specified as now done in this PR, that the `import *` in `__init__.py` would only import the elements in `__all__` regardless of other names being present that don't start with an underscore? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
