pitrou commented on code in PR #13556: URL: https://github.com/apache/arrow/pull/13556#discussion_r971066116
########## ci/scripts/install_sccache.sh: ########## @@ -0,0 +1,53 @@ +#!/usr/bin/env bash +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +set -e + +if [ "$#" -lt 1 -o "$#" -gt 3 ]; then + echo "Usage: $0 <build> <prefix> <arch> <version>" + echo "Will default to arch=x86_64 and version=0.3.0 " + exit 1 +fi + +BUILD=$1 +PREFIX=$2 +ARCH=${3:-x86_64} +VERSION=${4:-0.3.0} + +SCCACHE_URL="https://github.com/mozilla/sccache/releases/download/v0.3.0/sccache-v$VERSION-$ARCH-$BUILD.tar.gz"; Review Comment: Did you mean ```suggestion SCCACHE_URL="https://github.com/mozilla/sccache/releases/download/v$VERSION/sccache-v$VERSION-$ARCH-$BUILD.tar.gz"; ``` ########## ci/scripts/install_sccache.sh: ########## @@ -0,0 +1,53 @@ +#!/usr/bin/env bash +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +set -e + +if [ "$#" -lt 1 -o "$#" -gt 3 ]; then + echo "Usage: $0 <build> <prefix> <arch> <version>" + echo "Will default to arch=x86_64 and version=0.3.0 " + exit 1 +fi + +BUILD=$1 +PREFIX=$2 +ARCH=${3:-x86_64} +VERSION=${4:-0.3.0} + +SCCACHE_URL="https://github.com/mozilla/sccache/releases/download/v0.3.0/sccache-v$VERSION-$ARCH-$BUILD.tar.gz"; +SCCACHE_ARCHIVE=sccache.tar.gz + +# Download archive and checksum +curl -L $SCCACHE_URL --output $SCCACHE_ARCHIVE +curl -L $SCCACHE_URL.sha256 --output $SCCACHE_ARCHIVE.sha256 Review Comment: Just for the record, why not use `wget`? ########## cpp/cmake_modules/DefineOptions.cmake: ########## @@ -111,7 +111,10 @@ if(ARROW_DEFINE_OPTIONS) define_option(ARROW_POSITION_INDEPENDENT_CODE "Whether to create position-independent target" ON) - + + define_option(ARROW_USE_SCCACHE "Use sccache when compiling (if available),;\ +takes precdence over ccache if a storage backend is configured" ON) Review Comment: Also, move this below ARROW_USE_CCACHE? ########## cpp/cmake_modules/DefineOptions.cmake: ########## @@ -111,7 +111,10 @@ if(ARROW_DEFINE_OPTIONS) define_option(ARROW_POSITION_INDEPENDENT_CODE "Whether to create position-independent target" ON) - + + define_option(ARROW_USE_SCCACHE "Use sccache when compiling (if available),;\ +takes precdence over ccache if a storage backend is configured" ON) Review Comment: ```suggestion define_option(ARROW_USE_SCCACHE "Use sccache when compiling (if available), \ takes precedence over ccache if a storage backend is configured" ON) ``` ########## dev/tasks/tasks.yml: ########## @@ -951,7 +951,7 @@ tasks: custom_version: Unset artifacts: - r-lib__libarrow__bin__windows__arrow-[0-9\.]+\.zip - - r-lib__libarrow__bin__centos-7__arrow-[0-9\.]+\.zip + #- r-lib__libarrow__bin__centos-7__arrow-[0-9\.]+\.zip Review Comment: Add a comment explaining why? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
