askoa commented on issue #201: URL: https://github.com/apache/arrow-ballista/issues/201#issuecomment-1247207629
@andygrove Sorry for being little late for the party. My impression of the ticket was that the error quoted in the issue description is generated in the function [`from_proto_binary_op`](https://github.com/apache/arrow-ballista/blob/23f8cad74de7d3e08b202eb8c086083586d4511c/ballista/rust/core/src/serde/mod.rs#L199). To fix the issue, `StringConcat` has to be added to the `match op` block in that function. I also see there might be more issues in future, now that Bitwise operators are included in the `Operator` which is not yet added to the `match op` block. I wrote an [earlier comment](https://github.com/apache/arrow-ballista/issues/201#issuecomment-1242826089) that rather than keep updating the `match op` block in arrow-ballista project, its better to include a `from_str` function in the `arrow-datafusion` project. I see that the issue is closed without updating `match op` block. It would be great to know how the issue is fixed without updating the `match op` block. Could you please explain? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
