alamb commented on code in PR #3461:
URL: https://github.com/apache/arrow-datafusion/pull/3461#discussion_r971290873
##########
datafusion/core/src/physical_plan/aggregates/row_hash.rs:
##########
@@ -85,7 +85,9 @@ pub(crate) struct GroupedHashAggregateStreamV2 {
baseline_metrics: BaselineMetrics,
random_state: RandomState,
- finished: bool,
+
+ batch_size: usize,
Review Comment:
It would be great to use the configured `batch_size` rather than hard coding
this value:
https://github.com/apache/arrow-datafusion/blob/0388682e3d9f049cc7802da2f47aee73233810db/datafusion/core/src/execution/context.rs#L1253-L1260
Here is an example of how that is done in the sort operator:
https://github.com/apache/arrow-datafusion/blob/364c9cca07d623dd25737911d8155929a41bd167/datafusion/core/src/physical_plan/sorts/sort.rs#L137
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
