andygrove commented on code in PR #210:
URL: https://github.com/apache/arrow-ballista/pull/210#discussion_r971341022
##########
ballista/rust/core/src/serde/mod.rs:
##########
@@ -213,13 +213,23 @@ pub(crate) fn from_proto_binary_op(op: &str) ->
Result<Operator, BallistaError>
"Modulo" => Ok(Operator::Modulo),
"Like" => Ok(Operator::Like),
"NotLike" => Ok(Operator::NotLike),
+ "IsDistinctFrom" => Ok(Operator::IsDistinctFrom),
Review Comment:
Note that this method is copied from the private `from_proto_binary_op`
method in DataFusion. It would be better to make that public rather than
maintain a copy here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
