liukun4515 commented on PR #3470: URL: https://github.com/apache/arrow-datafusion/pull/3470#issuecomment-1247448285
> Thanks for all the good work @liukun4515 and @thinkharderdev > > I would be fine with merging this PR if we change it according to @thinkharderdev 's suggestion here https://github.com/apache/arrow-datafusion/pull/3470/files#r970907156) > > In either case, I think the most compelling solution would be to write some sort of end to end test that hits this condition so we don't have to discuss hypotheticals of what might/might not happen, > > For example, perhaps we can adapt one of the tests that runs against parquet files with a projected column and ensure predicates on those projected columns work when row filtering is enabled. tracked a issue for this https://github.com/apache/arrow-datafusion/issues/3492 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
