westonpace commented on PR #14131: URL: https://github.com/apache/arrow/pull/14131#issuecomment-1247454615
I figured I should tackle this to brush up on the rules for includes myself to try and help keep things clean going forwards. While I was at it I also did a bit of general header cleanup. The only structural changes were moving MapNode into its own file (I think @save-buffer has a PR to remove this at some point anyways so it seemed easier to do this than try and hide it's impl in some way) and converting IdStorage to a virtual class to hide its implementation (depended on internal hashing stuff). Attaching a snippet showing the compile tree from compiling `engine_substrait_consumption.cc` (which uses the engine API). [deps.txt](https://github.com/apache/arrow/files/9570898/deps.txt) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
