andygrove opened a new pull request, #212:
URL: https://github.com/apache/arrow-ballista/pull/212
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
N/A
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
I am starting to do some performance profiling and tuning and I cannot read
the plans because they are so huge.
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
This PR makes the output much less verbose for shuffle reader exec.
```
2022-09-15T02:03:17.337693Z INFO tokio-runtime-worker ThreadId(49)
ballista_scheduler::display: === [Xl4tDeB/15] Stage finished, physical plan
with metrics ===
ShuffleWriterExec: None, metrics=[output_rows=100, input_rows=100,
repart_time=1ns, write_time=534.050341ms]
GlobalLimitExec: skip=0, fetch=100, metrics=[output_rows=100,
elapsed_compute=1.839828ms, spill_count=0, spilled_bytes=0, mem_used=0]
SortExec: [c_customer_id@0 ASC NULLS LAST], metrics=[output_rows=8192,
elapsed_compute=518.201936ms, spill_count=0, spilled_bytes=0]
CoalescePartitionsExec, metrics=[output_rows=772575,
elapsed_compute=51.948µs, spill_count=0, spilled_bytes=0, mem_used=0]
ShuffleReaderExec: partitions=24, metrics=[fetch_time=392.660551ms]
```
Note that `ShuffleWriterExec` was already concise. This makes
`ShuffleReaderExec` more consistent with that.
Do we still have a need to output all the paths to all the location being
read? It was helpful early on in development for sure.
Ideally I would make this configurable but there does not seem to be an easy
way to hook this into the config system?
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
Yes, easier to read logs, less disk space used.
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
