mildbyte opened a new pull request, #2731: URL: https://github.com/apache/arrow-rs/pull/2731
# Which issue does this PR close? I couldn't find an issue for this in the arrow-rs repo. Some investigation here: https://github.com/splitgraph/seafowl/issues/112 # Rationale for this change The official Minio SDK uses `/?uploads=` as the URL when it initiates a multipart upload instead of `/?uploads` ([source](https://github.com/minio/minio-py/blob/master/minio/api.py#L1565-L1571)). This affects the query param string that goes into the AWSV4 signature and causes object_store to fail a signature check when initiating a multipart upload to Minio. **NOTE:** This is a deviation from the AWS S3 REST API docs: https://docs.aws.amazon.com/AmazonS3/latest/API/API_CreateMultipartUpload.html#API_CreateMultipartUpload_RequestSyntax (which do use `/?uploads`). **I haven't tested that this doesn't now break S3 multipart uploads.** As an alternative, we could instead alter the query param string in the signature itself, though from a very quick glance at the Minio [source code](https://github.com/minio/minio/blob/433b6fa8fe3cb9ab993eb76903c78a47651afa39/cmd/signature-v4.go#L375-L382) it looks like it uses the query string from the original request URL. # What changes are included in this PR? Change the URL to initiate a multipart upload to have `?uploads=` instead of `?uploads`. # Are there any user-facing changes? None -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
