xudong963 commented on code in PR #3482:
URL: https://github.com/apache/arrow-datafusion/pull/3482#discussion_r971964861


##########
datafusion/core/tests/sql/subqueries.rs:
##########
@@ -289,6 +289,139 @@ async fn tpch_q17_correlated() -> Result<()> {
     Ok(())
 }
 
+// Fix for issue#78 join predicates from inside of OR expr also pulled up 
properly.
+#[tokio::test]
+async fn tpch_q19_pull_predicates_to_innerjoin() -> Result<()> {

Review Comment:
   In fact, tests in `subqueries.rs` are about correlated subqueries(you can 
know by the file name directly), not all tpch queries. 
   
   So you need to find a proper place for the test.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to