zeroshade commented on code in PR #127:
URL: https://github.com/apache/arrow-adbc/pull/127#discussion_r972101852
##########
go/adbc/drivermgr/wrapper_sqlite_test.go:
##########
@@ -46,9 +46,10 @@ type DriverMgrSuite struct {
func (dm *DriverMgrSuite) SetupSuite() {
dm.ctx = context.TODO()
dm.drv = &drivermgr.Driver{}
- dm.drv.SetOptions(map[string]string{
+ err := dm.drv.SetOptions(map[string]string{
Review Comment:
For each of these rather than getting the `err` and calling `NoError` I'd
probably just wrap them with `NoError` in the first place.
Not necessary, just a style thing. Up to you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
