dianaclarke commented on pull request #8312:
URL: https://github.com/apache/arrow/pull/8312#issuecomment-702319356


   If I do something like the following & revert the Python changes, I get this 
result.
   
   ```
   // cpp/src/arrow/python/extension_type.cc
   std::string PyExtensionType::ToString() const {
     return this->storage_type()->ToString();
   }
   
   // cpp/src/arrow/python/extension_type.h
   std::string ToString() const override;
   ```
   
   ```
   >>> ty = IntegerType()
   >>> ty
   IntegerType(int64)
   >>> pa.DataType.__str__(ty)
   'int64'
   ```
   
   And if I keep the Python changes & the C++ changes, I see this:
   
   ```
   >>> ty = IntegerType()
   >>> ty
   IntegerType(DataType(int64))
   >>> pa.DataType.__str__(ty)
   'int64'
   ```
   
   What are the desired return values?
   
   PS. I don't want to take up too much of your time. I won't be offended if 
you decide it's quicker to just implement this yourself. That, and I don't know 
C++, so anything I do attempt should be heavily scrutinized ;)
   
   Thanks again for taking the time to review my first attempt and pointing me 
in the right direction.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to