metesynnada opened a new issue, #3511:
URL: https://github.com/apache/arrow-datafusion/issues/3511
**Describe the bug**
`PartialOrd` implementation of `ScalarValue` types gives `None` for
different types and it is automatically cast to `false`. I think this is the
wrong behavior and introduces silent errors.
**To Reproduce**
Below test code shows the error
```rust
fn ord_diff_type() {
assert_eq!(
true,
(ScalarValue::Float32(Some(2.0)) < ScalarValue::Int32(Some(3)))
);
}
```
**Expected behavior**
I expected comparison to be true, however comparison
`(ScalarValue::Float32(Some(2.0)) < ScalarValue::Int32(Some(3)))` returns
`false`. Hence assertion fails. I think returning `false` here is misleading.
This comparison either should produce an error or return `true`. If we do the
comparison below it works as expected., since they have the same type
```rust
fn ord_same_type() {
assert_eq!(
true,
(ScalarValue::Int32(Some(2))<
ScalarValue::Int32(Some(3)))
);
}
```
**Additional context**
I think casting the left or right side of the comparison to the larger type
would solve the problem. The relevant section of the code is below
https://github.com/apache/arrow-datafusion/blob/66dd253d2e0cdd00c8d3611f2ca470b9cde48abc/datafusion/common/src/scalar.rs#L196
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
