andygrove commented on code in PR #52: URL: https://github.com/apache/arrow-datafusion-python/pull/52#discussion_r973069389
########## src/config.rs: ########## @@ -0,0 +1,80 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +use pyo3::prelude::*; +use pyo3::types::*; + +use datafusion::config::ConfigOptions; +use datafusion_common::ScalarValue; + +#[pyclass(name = "Config", module = "datafusion", subclass)] +#[derive(Clone)] +pub(crate) struct PyConfig { + config: ConfigOptions, +} + +#[pymethods] +impl PyConfig { + #[new] + fn py_new() -> Self { + Self { + config: ConfigOptions::new(), + } + } + + /// Get configurations from environment variables + #[staticmethod] + pub fn from_env() -> Self { + Self { + config: ConfigOptions::from_env(), + } + } + + /// Get a configuration option + pub fn get(&mut self, key: &str, py: Python) -> PyResult<PyObject> { + Ok(self.config.get(key).into_py(py)) + } + + /// Set a configuration option + pub fn set(&mut self, key: &str, value: PyObject, py: Python) { + self.config.set(key, py_obj_to_scalar_value(py, value)) + } + + /// Get all configuration options + pub fn get_all(&mut self, py: Python) -> PyResult<PyObject> { + let dict = PyDict::new(py); + for (key, value) in self.config.options() { + dict.set_item(key, value.clone().into_py(py))?; + } + Ok(dict.into()) + } +} + +/// Convert a python object to a ScalarValue +fn py_obj_to_scalar_value(py: Python, obj: PyObject) -> ScalarValue { + if let Ok(value) = obj.extract::<bool>(py) { + ScalarValue::Boolean(Some(value)) + } else if let Ok(value) = obj.extract::<i64>(py) { + ScalarValue::Int64(Some(value)) Review Comment: I think we should use UInt64 here. We don't have any Int64 configs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
