tustvold commented on code in PR #2746:
URL: https://github.com/apache/arrow-rs/pull/2746#discussion_r973140513
##########
arrow/src/array/array_decimal.rs:
##########
@@ -284,7 +284,11 @@ impl<T: DecimalType> DecimalArray<T> {
// safety: self.data is valid DataType::Decimal as checked above
let new_data_type = Self::TYPE_CONSTRUCTOR(precision, scale);
- Ok(self.data().clone().with_data_type(new_data_type).into())
+ let data = self.data().clone().into_builder().data_type(new_data_type);
Review Comment:
This method was previously pub(crate), I opted to just remove it in favour
of the into_builder plumbing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
