tustvold commented on code in PR #2717:
URL: https://github.com/apache/arrow-rs/pull/2717#discussion_r973242513
##########
arrow/src/compute/kernels/arithmetic.rs:
##########
@@ -1225,12 +1143,17 @@ where
pub fn divide_dyn(left: &dyn Array, right: &dyn Array) -> Result<ArrayRef> {
match left.data_type() {
DataType::Dictionary(_, _) => {
- typed_dict_math_op!(left, right, |a, b| a / b,
math_divide_checked_op_dict)
+ typed_dict_math_op!(
+ left,
+ right,
+ |a, b| a.div_checked(b),
Review Comment:
But the only thing that is checked is if the rhs is 0?
https://doc.rust-lang.org/std/primitive.i32.html#method.checked_div
(which is redundant as this has already been checked, and so we can/should
simplify the logic but it won't be user-visible)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
