alamb commented on code in PR #3519: URL: https://github.com/apache/arrow-datafusion/pull/3519#discussion_r973295089
########## datafusion/core/src/lib.rs: ########## @@ -161,11 +161,17 @@ //! * Projection: [`ProjectionExec`](physical_plan::projection::ProjectionExec) //! * Filter: [`FilterExec`](physical_plan::filter::FilterExec) //! * Grouped and non-grouped aggregations: [`AggregateExec`](physical_plan::aggregates::AggregateExec) +//! * Hash Join: [`HashJoinExec`](physical_plan::hash_join::HashJoinExec) +//! * Cross Join: [`HashJoinExec`](physical_plan::cross_join::CrossJoinExec) +//! * Sort Merge Join: [`SortExec`](physical_plan::sort_merge_join::SortMergeJoinExec) +//! * Union: [`SortExec`](physical_plan::union::UnionExec) //! * Sort: [`SortExec`](physical_plan::sorts::sort::SortExec) //! * Coalesce partitions: [`CoalescePartitionsExec`](physical_plan::coalesce_partitions::CoalescePartitionsExec) //! * Limit: [`LocalLimitExec`](physical_plan::limit::LocalLimitExec) and [`GlobalLimitExec`](physical_plan::limit::GlobalLimitExec) -//! * Scan a CSV: [`CsvExec`](physical_plan::file_format::CsvExec) -//! * Scan a Parquet: [`ParquetExec`](physical_plan::file_format::ParquetExec) +//! * Scan CSV: [`CsvExec`](physical_plan::file_format::CsvExec) +//! * Scan Parquet: [`ParquetExec`](physical_plan::file_format::ParquetExec) +//! * Scan Avro: [`ParquetExec`](physical_plan::file_format::AvroExec) Review Comment: ```suggestion //! * Scan Avro: [`AvroExec`](physical_plan::file_format::AvroExec) ``` ########## datafusion/core/src/lib.rs: ########## @@ -161,11 +161,17 @@ //! * Projection: [`ProjectionExec`](physical_plan::projection::ProjectionExec) //! * Filter: [`FilterExec`](physical_plan::filter::FilterExec) //! * Grouped and non-grouped aggregations: [`AggregateExec`](physical_plan::aggregates::AggregateExec) +//! * Hash Join: [`HashJoinExec`](physical_plan::hash_join::HashJoinExec) +//! * Cross Join: [`HashJoinExec`](physical_plan::cross_join::CrossJoinExec) +//! * Sort Merge Join: [`SortExec`](physical_plan::sort_merge_join::SortMergeJoinExec) +//! * Union: [`SortExec`](physical_plan::union::UnionExec) //! * Sort: [`SortExec`](physical_plan::sorts::sort::SortExec) //! * Coalesce partitions: [`CoalescePartitionsExec`](physical_plan::coalesce_partitions::CoalescePartitionsExec) //! * Limit: [`LocalLimitExec`](physical_plan::limit::LocalLimitExec) and [`GlobalLimitExec`](physical_plan::limit::GlobalLimitExec) -//! * Scan a CSV: [`CsvExec`](physical_plan::file_format::CsvExec) -//! * Scan a Parquet: [`ParquetExec`](physical_plan::file_format::ParquetExec) +//! * Scan CSV: [`CsvExec`](physical_plan::file_format::CsvExec) +//! * Scan Parquet: [`ParquetExec`](physical_plan::file_format::ParquetExec) +//! * Scan Avro: [`ParquetExec`](physical_plan::file_format::AvroExec) +//! * Scan newline-delimited JSON: [`ParquetExec`](physical_plan::file_format::NdJsonExec) Review Comment: ```suggestion //! * Scan newline-delimited JSON: [`NdJsonExec`](physical_plan::file_format::NdJsonExec) ``` ########## datafusion/core/src/lib.rs: ########## @@ -161,11 +161,17 @@ //! * Projection: [`ProjectionExec`](physical_plan::projection::ProjectionExec) //! * Filter: [`FilterExec`](physical_plan::filter::FilterExec) //! * Grouped and non-grouped aggregations: [`AggregateExec`](physical_plan::aggregates::AggregateExec) +//! * Hash Join: [`HashJoinExec`](physical_plan::hash_join::HashJoinExec) +//! * Cross Join: [`HashJoinExec`](physical_plan::cross_join::CrossJoinExec) +//! * Sort Merge Join: [`SortExec`](physical_plan::sort_merge_join::SortMergeJoinExec) Review Comment: ```suggestion //! * Sort Merge Join: [`SortMergeJoinExec`](physical_plan::sort_merge_join::SortMergeJoinExec) ``` ########## datafusion/core/src/lib.rs: ########## @@ -161,11 +161,17 @@ //! * Projection: [`ProjectionExec`](physical_plan::projection::ProjectionExec) //! * Filter: [`FilterExec`](physical_plan::filter::FilterExec) //! * Grouped and non-grouped aggregations: [`AggregateExec`](physical_plan::aggregates::AggregateExec) +//! * Hash Join: [`HashJoinExec`](physical_plan::hash_join::HashJoinExec) +//! * Cross Join: [`HashJoinExec`](physical_plan::cross_join::CrossJoinExec) Review Comment: ```suggestion //! * Cross Join: [`CrossJoinExec`](physical_plan::cross_join::CrossJoinExec) ``` ########## datafusion/core/src/lib.rs: ########## @@ -161,11 +161,17 @@ //! * Projection: [`ProjectionExec`](physical_plan::projection::ProjectionExec) //! * Filter: [`FilterExec`](physical_plan::filter::FilterExec) //! * Grouped and non-grouped aggregations: [`AggregateExec`](physical_plan::aggregates::AggregateExec) +//! * Hash Join: [`HashJoinExec`](physical_plan::hash_join::HashJoinExec) +//! * Cross Join: [`HashJoinExec`](physical_plan::cross_join::CrossJoinExec) +//! * Sort Merge Join: [`SortExec`](physical_plan::sort_merge_join::SortMergeJoinExec) +//! * Union: [`SortExec`](physical_plan::union::UnionExec) Review Comment: ```suggestion //! * Union: [`UnionExec`](physical_plan::union::UnionExec) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
