alamb commented on code in PR #2752:
URL: https://github.com/apache/arrow-rs/pull/2752#discussion_r973506049
##########
dev/release/verify-release-candidate.sh:
##########
@@ -116,21 +116,16 @@ test_source_distribution() {
export ARROW_TEST_DATA=$PWD/arrow-testing-data/data
export PARQUET_TEST_DATA=$PWD/parquet-testing-data/data
- # use local modules because we don't publish modules to crates.io yet
- sed \
- -i.bak \
- -E \
- -e 's/^arrow = "([^"]*)"/arrow = { version = "\1", path = "..\/arrow" }/g'
\
- -e 's/^parquet = "([^"]*)"/parquet = { version = "\1", path =
"..\/parquet" }/g' \
- */Cargo.toml
-
(cd arrow && cargo build && cargo test)
(cd arrow-flight && cargo build && cargo test)
(cd parquet && cargo build && cargo test)
(cd parquet_derive && cargo build && cargo test)
- # verify that the crates can be published to crates.io
- pushd arrow
+ # verify that the leaf crates can be published to crates.io
+ # we can't verify crates that depend on others
+ # (because the others haven't yet been published to crates.io)
+
+ pushd arrow-buffer
cargo publish --dry-run
popd
Review Comment:
yeah, it would be great to verify all the crates...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
