viirya commented on code in PR #2740: URL: https://github.com/apache/arrow-rs/pull/2740#discussion_r973512682
########## arrow/src/compute/kernels/arithmetic.rs: ########## @@ -570,6 +596,28 @@ macro_rules! math_dict_op { }}; } +/// Helper function to perform math lambda function on values from two dictionary arrays, this +/// version does not attempt to use SIMD explicitly (though the compiler may auto vectorize) +macro_rules! math_dict_checked_op { Review Comment: We can get rid of this macro actually. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org