HaoYang670 opened a new pull request, #2756:
URL: https://github.com/apache/arrow-rs/pull/2756
Signed-off-by: remzi <1371656737...@gmail.com>
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #2753.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
1. Add 3 kinds of modulus ops:
- `mod_wrapping`: panics when divisor is 0 and returns 0 when overflow
occurs (signed_int::MIN % -1)
- `mod_checked_divide_by_zero`: only checks the `DivideByZero` error and
never panic.
- `mod_fully_checked`: checks the `DivideByZero` error and `Overflow` error,
never panic.
2. Update `modulus` and `modulus_scalar` to use `mod_checked_divide_by_zero`
3. Add tests to check the behaviour of `n % 0` and overflow.
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
