kmitchener commented on issue #3523: URL: https://github.com/apache/arrow-datafusion/issues/3523#issuecomment-1250051220
Thanks @liukun4515. It's all the issues listed in #3480 as well: * #3437 * #3479 Per other discussions, I'd like to help here. I think the general plan should be something like: * stabilize and add tests * move the decimal implementation code to arrow-rs * have the discussion about Decimal128/256 implementation that's going on arrow-rs and agree on path forward for implementation details * meanwhile in DataFusion, continue to improve use of Decimals in the math functions, sql literals, scientific notation support, etc. I think there will be some churn .. for example, to fix #3521 , we could use the `num` crate that arrow-rs already uses and fix the implementation of the decimal divide method here. However, that's only a fine short-term solution for stabilization and we'd need to remove the `num` crate again when we finally move the Decimal kernel implementation over to arrow-rs. Is that acceptable? Also, how do you deal with the synchronization between the projects? for example, some DF issues are due to the decimal cast code in arrow-rs .. how do we test the fixes? now that we're at the beginning of the dev cycle for 13, can we change DF to pin it to arrow-rs git revs? cc @alamb -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
