alamb commented on code in PR #3482:
URL: https://github.com/apache/arrow-datafusion/pull/3482#discussion_r973573703


##########
datafusion/core/src/execution/context.rs:
##########
@@ -1437,6 +1438,7 @@ impl SessionState {
             Arc::new(ScalarSubqueryToJoin::new()),
             Arc::new(SubqueryFilterToJoin::new()),
             Arc::new(EliminateFilter::new()),
+            Arc::new(ReduceCrossJoin::new()),

Review Comment:
   I agree that a static ordering is likely to produce non optimal plans in 
some cases. Running in a loop until a "fixed point" is a reasonable however, 
then there is a danger of optimizer ping-pong (aka one optimizer pass makes a 
change and then the other undoes it)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to