andygrove commented on code in PR #240:
URL: https://github.com/apache/arrow-ballista/pull/240#discussion_r973750593
##########
dev/docker/ballista.dockerfile:
##########
@@ -49,7 +49,9 @@ ARG PROTOC_VERSION=21.4
RUN mkdir /tmp/protoc
WORKDIR /tmp/protoc
-RUN export PROTO_ZIP="protoc-${PROTOC_VERSION}-linux-x86_64.zip" && \
+RUN CPU_ARCH=`uname -m` && \
+ if [ $CPU_ARCH=="aarch64" ]; then CPU_ARCH="aarch_64"; fi && \
Review Comment:
The condition here is always true for me (on Ubuntu 20.04.4 LTS) unless I
add spaces around the `==`.
```suggestion
if [ $CPU_ARCH == "aarch64" ]; then CPU_ARCH="aarch_64"; fi && \
```
Here is how I tested this:
test 1
```bash
#!/bin/bash
CPU_ARCH=`uname -m`
echo $CPU_ARCH
if [ $CPU_ARCH=="aarch64" ]; then CPU_ARCH="aarch_64"; fi
echo $CPU_ARCH
```
Produces:
```
x86_64
aarch_64
```
test 2
```bash
#!/bin/bash
CPU_ARCH=`uname -m`
echo $CPU_ARCH
if [ $CPU_ARCH == "aarch64" ]; then CPU_ARCH="aarch_64"; fi
echo $CPU_ARCH
```
produces
```
x86_64
x86_64
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
