alamb commented on code in PR #3510:
URL: https://github.com/apache/arrow-datafusion/pull/3510#discussion_r974666565
##########
datafusion/optimizer/src/type_coercion.rs:
##########
@@ -98,6 +101,81 @@ impl ExprRewriter for TypeCoercionRewriter<'_> {
fn mutate(&mut self, expr: Expr) -> Result<Expr> {
match expr {
+ Expr::IsTrue(expr) => {
+ let expr = is_true(get_casted_expr_for_bool_op(&expr,
&self.schema)?);
+ expr.rewrite(&mut self.const_evaluator)
+ }
+ Expr::IsNotTrue(expr) => {
+ let expr = is_not_true(get_casted_expr_for_bool_op(&expr,
&self.schema)?);
+ expr.rewrite(&mut self.const_evaluator)
+ }
+ Expr::IsFalse(expr) => {
+ let expr = is_false(get_casted_expr_for_bool_op(&expr,
&self.schema)?);
+ expr.rewrite(&mut self.const_evaluator)
+ }
+ Expr::IsNotFalse(expr) => {
+ let expr =
+ is_not_false(get_casted_expr_for_bool_op(&expr,
&self.schema)?);
+ expr.rewrite(&mut self.const_evaluator)
+ }
+ Expr::Like {
+ negated,
+ expr,
+ pattern,
+ escape_char,
+ } => {
+ let left_type = expr.get_type(&self.schema)?;
+ let right_type = pattern.get_type(&self.schema)?;
+ let coerced_type =
+ coerce_types(&left_type, &Operator::Like, &right_type)?;
+ let expr = Box::new(expr.cast_to(&coerced_type,
&self.schema)?);
+ let pattern = Box::new(pattern.cast_to(&coerced_type,
&self.schema)?);
+ let expr = Expr::Like {
+ negated,
+ expr,
+ pattern,
+ escape_char,
+ };
+ expr.rewrite(&mut self.const_evaluator)
Review Comment:
🤔 maybe in the long term figuring out how to avoid having to remember to
call the const evaluator each struct would be good -- as it too does a expr
tree walk
So this algorithm is at least `O(n^2)` in the number of items in the expr
tree.
I don't think it is important to do in this PR, but I think it is worth
keeping in mind as we proceed or if we see the planner being a bit slow
##########
datafusion/optimizer/src/type_coercion.rs:
##########
@@ -98,6 +101,81 @@ impl ExprRewriter for TypeCoercionRewriter<'_> {
fn mutate(&mut self, expr: Expr) -> Result<Expr> {
match expr {
+ Expr::IsTrue(expr) => {
+ let expr = is_true(get_casted_expr_for_bool_op(&expr,
&self.schema)?);
+ expr.rewrite(&mut self.const_evaluator)
+ }
+ Expr::IsNotTrue(expr) => {
+ let expr = is_not_true(get_casted_expr_for_bool_op(&expr,
&self.schema)?);
+ expr.rewrite(&mut self.const_evaluator)
+ }
+ Expr::IsFalse(expr) => {
+ let expr = is_false(get_casted_expr_for_bool_op(&expr,
&self.schema)?);
+ expr.rewrite(&mut self.const_evaluator)
+ }
+ Expr::IsNotFalse(expr) => {
+ let expr =
+ is_not_false(get_casted_expr_for_bool_op(&expr,
&self.schema)?);
+ expr.rewrite(&mut self.const_evaluator)
+ }
+ Expr::Like {
+ negated,
+ expr,
+ pattern,
+ escape_char,
+ } => {
+ let left_type = expr.get_type(&self.schema)?;
+ let right_type = pattern.get_type(&self.schema)?;
+ let coerced_type =
+ coerce_types(&left_type, &Operator::Like, &right_type)?;
+ let expr = Box::new(expr.cast_to(&coerced_type,
&self.schema)?);
+ let pattern = Box::new(pattern.cast_to(&coerced_type,
&self.schema)?);
+ let expr = Expr::Like {
+ negated,
+ expr,
+ pattern,
+ escape_char,
+ };
+ expr.rewrite(&mut self.const_evaluator)
+ }
+ Expr::ILike {
+ negated,
+ expr,
+ pattern,
+ escape_char,
+ } => {
+ let left_type = expr.get_type(&self.schema)?;
+ let right_type = pattern.get_type(&self.schema)?;
+ let coerced_type =
+ coerce_types(&left_type, &Operator::Like, &right_type)?;
+ let expr = Box::new(expr.cast_to(&coerced_type,
&self.schema)?);
+ let pattern = Box::new(pattern.cast_to(&coerced_type,
&self.schema)?);
+ let expr = Expr::ILike {
+ negated,
+ expr,
+ pattern,
+ escape_char,
+ };
+ expr.rewrite(&mut self.const_evaluator)
+ }
+ Expr::IsUnknown(expr) => {
+ // will convert the
binary(expr,IsNotDistinctFrom,lit(Boolean(None));
+ let left_type = expr.get_type(&self.schema)?;
+ let right_type = DataType::Boolean;
+ let coerced_type =
+ coerce_types(&left_type, &Operator::IsNotDistinctFrom,
&right_type)?;
Review Comment:
Is there a reason this isn't `Operator::IsUnknown`?
##########
datafusion/optimizer/src/type_coercion.rs:
##########
@@ -98,6 +101,81 @@ impl ExprRewriter for TypeCoercionRewriter<'_> {
fn mutate(&mut self, expr: Expr) -> Result<Expr> {
match expr {
+ Expr::IsTrue(expr) => {
+ let expr = is_true(get_casted_expr_for_bool_op(&expr,
&self.schema)?);
+ expr.rewrite(&mut self.const_evaluator)
+ }
+ Expr::IsNotTrue(expr) => {
+ let expr = is_not_true(get_casted_expr_for_bool_op(&expr,
&self.schema)?);
+ expr.rewrite(&mut self.const_evaluator)
+ }
+ Expr::IsFalse(expr) => {
+ let expr = is_false(get_casted_expr_for_bool_op(&expr,
&self.schema)?);
+ expr.rewrite(&mut self.const_evaluator)
+ }
+ Expr::IsNotFalse(expr) => {
+ let expr =
+ is_not_false(get_casted_expr_for_bool_op(&expr,
&self.schema)?);
+ expr.rewrite(&mut self.const_evaluator)
+ }
+ Expr::Like {
+ negated,
+ expr,
+ pattern,
+ escape_char,
+ } => {
+ let left_type = expr.get_type(&self.schema)?;
+ let right_type = pattern.get_type(&self.schema)?;
+ let coerced_type =
+ coerce_types(&left_type, &Operator::Like, &right_type)?;
+ let expr = Box::new(expr.cast_to(&coerced_type,
&self.schema)?);
+ let pattern = Box::new(pattern.cast_to(&coerced_type,
&self.schema)?);
+ let expr = Expr::Like {
+ negated,
+ expr,
+ pattern,
+ escape_char,
+ };
+ expr.rewrite(&mut self.const_evaluator)
+ }
+ Expr::ILike {
+ negated,
+ expr,
+ pattern,
+ escape_char,
+ } => {
+ let left_type = expr.get_type(&self.schema)?;
+ let right_type = pattern.get_type(&self.schema)?;
+ let coerced_type =
+ coerce_types(&left_type, &Operator::Like, &right_type)?;
+ let expr = Box::new(expr.cast_to(&coerced_type,
&self.schema)?);
+ let pattern = Box::new(pattern.cast_to(&coerced_type,
&self.schema)?);
+ let expr = Expr::ILike {
+ negated,
+ expr,
+ pattern,
+ escape_char,
+ };
+ expr.rewrite(&mut self.const_evaluator)
+ }
+ Expr::IsUnknown(expr) => {
+ // will convert the
binary(expr,IsNotDistinctFrom,lit(Boolean(None));
+ let left_type = expr.get_type(&self.schema)?;
+ let right_type = DataType::Boolean;
+ let coerced_type =
+ coerce_types(&left_type, &Operator::IsNotDistinctFrom,
&right_type)?;
+ let expr = is_unknown(expr.cast_to(&coerced_type,
&self.schema)?);
+ expr.rewrite(&mut self.const_evaluator)
+ }
+ Expr::IsNotUnknown(expr) => {
+ // will convert the
binary(expr,IsDistinctFrom,lit(Boolean(None));
+ let left_type = expr.get_type(&self.schema)?;
+ let right_type = DataType::Boolean;
+ let coerced_type =
+ coerce_types(&left_type, &Operator::IsDistinctFrom,
&right_type)?;
Review Comment:
Likewise here, it seem strange that this is not `Operator::IsNotUnknown`
##########
datafusion/optimizer/src/type_coercion.rs:
##########
@@ -203,6 +297,15 @@ impl ExprRewriter for TypeCoercionRewriter<'_> {
}
}
+// Support the `IsTure` `IsNotTrue` `IsFalse` `IsNotFalse` type coercion.
Review Comment:
```suggestion
// Support the `IsTrue` `IsNotTrue` `IsFalse` `IsNotFalse` type coercion.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
