poonai commented on code in PR #3473:
URL: https://github.com/apache/arrow-datafusion/pull/3473#discussion_r974923815
##########
datafusion/core/src/physical_plan/aggregates/row_hash.rs:
##########
@@ -227,11 +227,6 @@ fn group_aggregate_batch(
for group_values in grouping_by_values {
let group_rows: Vec<Vec<u8>> = create_group_rows(group_values,
group_schema);
- // evaluate the aggregation expressions.
Review Comment:
I've noticed that in the master, aggregation expression is continuously
evaluated for each loop which is not same as `GroupedHashAggregateStream`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
