tustvold opened a new pull request, #2760: URL: https://github.com/apache/arrow-rs/pull/2760
# Which issue does this PR close? Follow on to #2597 # Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> ``` $ time cargo build --release --no-default-features ________________________________________________________ Executed in 22.13 secs fish external usr time 120.80 secs 561.00 micros 120.80 secs sys time 3.70 secs 107.00 micros 3.69 secs ``` ``` $ time cargo build --release --no-default-features --features dyn_arith_dict ________________________________________________________ Executed in 38.73 secs fish external usr time 167.26 secs 613.00 micros 167.26 secs sys time 4.26 secs 106.00 micros 4.26 secs ``` # What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> Gates arithmetic operations between primitive dictionary arrays behind a feature flag. Primitive dictionaries are fairly niche, array operations on primitive dictionaries are even more niche. I think the benefits to compilation time justify the overheads of an additional feature flag # Are there any user-facing changes? Arithmetic operations on dictionaries now require enabling via a feature flag <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!--- If there are any breaking changes to public APIs, please add the `breaking change` label. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org