lidavidm commented on code in PR #14134:
URL: https://github.com/apache/arrow/pull/14134#discussion_r975406605
##########
java/adapter/jdbc/src/main/java/org/apache/arrow/adapter/jdbc/JdbcToArrowConfigBuilder.java:
##########
@@ -216,7 +216,7 @@ public JdbcToArrowConfigBuilder setTargetBatchSize(int
targetBatchSize) {
* Defaults to wrapping {@link
JdbcToArrowUtils#getArrowTypeFromJdbcType(JdbcFieldInfo, Calendar)}.
*/
public JdbcToArrowConfigBuilder setJdbcToArrowTypeConverter(
Review Comment:
Is it possible to add an overload to accept a `Function` still for backwards
compatibility?
##########
java/adapter/jdbc/src/main/java/org/apache/arrow/adapter/jdbc/JdbcToArrowConfigBuilder.java:
##########
@@ -216,7 +216,7 @@ public JdbcToArrowConfigBuilder setTargetBatchSize(int
targetBatchSize) {
* Defaults to wrapping {@link
JdbcToArrowUtils#getArrowTypeFromJdbcType(JdbcFieldInfo, Calendar)}.
*/
public JdbcToArrowConfigBuilder setJdbcToArrowTypeConverter(
Review Comment:
Alternatively - we could add the column index as a field in `JdbcFieldInfo`
so that signatures do not have to change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
