rtpsw commented on code in PR #14172:
URL: https://github.com/apache/arrow/pull/14172#discussion_r975615795
##########
cpp/src/arrow/compute/exec/asof_join_node_test.cc:
##########
@@ -633,6 +633,11 @@ struct BasicTest {
using AsofJoinBasicParams = std::tuple<std::function<void(BasicTest&)>,
std::string>;
+void PrintTo(const AsofJoinBasicParams& x, ::std::ostream* os) {
+ *os << "AsofJoinBasicParams: " << std::get<0>(x).target_type().name() << " -
"
+ << std::get<1>(x);
Review Comment:
@westonpace is correct. As long as the [test
names](https://github.com/apache/arrow/blob/40ec95646962cccdcd62032c80e8506d4c275bc6/cpp/src/arrow/compute/exec/asof_join_node_test.cc#L915-L920)
are unique, the test name inserted with `std::get<1>(x)` will be sufficient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
