kmitchener commented on code in PR #3552:
URL: https://github.com/apache/arrow-datafusion/pull/3552#discussion_r975714732
##########
datafusion/expr/src/binary_rule.rs:
##########
@@ -153,7 +153,7 @@ fn bitwise_coercion(left_type: &DataType, right_type:
&DataType) -> Option<DataT
return None;
}
- if left_type == right_type && !is_dictionary(left_type) {
+ if left_type == right_type {
Review Comment:
this is_dictionary() call would never be true anyway due to the checks
above. probably copy/paste duplication?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
