comphead commented on PR #3522: URL: https://github.com/apache/arrow-datafusion/pull/3522#issuecomment-1253059045
> Apologies for not getting to this sooner. I have been overstretched recently. Here is my view on how we should implement this (we don't have to do all of this in this PR, though). > > In the `set` methods, I think it makes sense to check if the config is one of the built-in (pre-defined) configs, and if so, then check that the value is the correct type and return a `Result`. > > If we do the validation when setting configs, then there is no need to return a `Result` on the `get` methods. I like the idea of returning `Option` here and logging a warning if the config option is set but has the wrong datatype (this should not be possible in most cases if we are verifying the values in the `set` method). Thanks @andygrove. Implemented exactly like discussed. I will create another PR for setting values and checking if they are part of built in configs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
