paddyhoran commented on a change in pull request #8331:
URL: https://github.com/apache/arrow/pull/8331#discussion_r499105205
##########
File path: rust/arrow/src/util/pretty.rs
##########
@@ -126,15 +130,56 @@ fn array_value_to_string(column: array::ArrayRef, row:
usize) -> Result<String>
DataType::Time64(unit) if *unit == TimeUnit::Nanosecond => {
make_string!(array::Time64NanosecondArray, column, row)
}
+ DataType::Dictionary(index_type, _value_type) => match **index_type {
+ DataType::Int8 => dict_array_value_to_string::<Int8Type>(column,
row),
+ DataType::Int16 => dict_array_value_to_string::<Int16Type>(column,
row),
+ DataType::Int32 => dict_array_value_to_string::<Int32Type>(column,
row),
+ DataType::Int64 => dict_array_value_to_string::<Int64Type>(column,
row),
+ DataType::UInt8 => dict_array_value_to_string::<UInt8Type>(column,
row),
+ DataType::UInt16 =>
dict_array_value_to_string::<UInt16Type>(column, row),
+ DataType::UInt32 =>
dict_array_value_to_string::<UInt32Type>(column, row),
+ DataType::UInt64 =>
dict_array_value_to_string::<UInt64Type>(column, row),
+ _ => Err(ArrowError::InvalidArgumentError(format!(
+ "Unsupported index type {:?} type for {:?} in repl.",
Review comment:
I think this (pretty printing) was part of DataFusion's cli to begin
with but was moved into `arrow` as it was generally useful. I don't understand
repl in this context either. I suggest updating it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
