Dandandan commented on code in PR #3545:
URL: https://github.com/apache/arrow-datafusion/pull/3545#discussion_r976783193


##########
datafusion/core/src/physical_plan/sorts/sort.rs:
##########
@@ -273,6 +275,7 @@ impl MemoryConsumer for ExternalSorter {
             &self.expr,
             self.session_config.batch_size(),
             tracking_metrics,
+            self.fetch,

Review Comment:
   Yeah maybe the spilling could see the remaining batch is so small it could 
add the sorted data to memory again - avoiding the spill 🤔



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to