davisusanibar commented on code in PR #14066:
URL: https://github.com/apache/arrow/pull/14066#discussion_r976787357
##########
java/memory/memory-core/pom.xml:
##########
@@ -37,4 +37,58 @@
</dependency>
</dependencies>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-surefire-plugin</artifactId>
+
+ <configuration>
+ <excludes>
+ <!-- Test is only useful when NOT running with add-opens -->
+ <exclude>**/TestOpens.java</exclude>
+ </excludes>
+ </configuration>
+ </plugin>
+ </plugins>
+ </build>
+
+ <profiles>
+ <profile>
+ <id>opens-tests</id>
+ <!-- Run tests WITHOUT add-opens to make sure we fail-fast -->
+ <activation>
+ <jdk>[16,]</jdk>
+ </activation>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-surefire-plugin</artifactId>
+
+ <executions>
+ <execution>
+ <id>opens-tests</id>
+ <phase>test</phase>
+ <goals>
+ <goal>test</goal>
+ </goals>
+ <configuration>
+ <!-- Dummy value to stop inheriting the default add-opens
flag -->
+ <argLine>-Dfoo=bar</argLine>
Review Comment:
I mean parent project configure `maven-surefire-plugin` to add
`<argLine>--add-opens=java.base/java.nio=ALL-UNNAMED</argLine>`, if the plan is
to TestOpens.java fail will be needed to reset Surefire parent configuration
When you run the TestOpens test it's throw the exception?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
