alamb commented on code in PR #3535:
URL: https://github.com/apache/arrow-datafusion/pull/3535#discussion_r976796253
##########
datafusion/proto/src/lib.rs:
##########
@@ -422,6 +425,23 @@ mod roundtrip_tests {
ScalarValue::TimestampSecond(Some(i64::MAX), None),
ScalarValue::TimestampSecond(Some(0), Some("UTC".to_string())),
ScalarValue::TimestampSecond(None, None),
+
ScalarValue::IntervalDayTime(Some(IntervalDayTimeType::make_value(0, 0))),
Review Comment:
It appears there were no round trip tests for IntervalDayTime either, so I
added them as well
##########
datafusion/proto/proto/datafusion.proto:
##########
@@ -733,9 +733,18 @@ message ScalarDictionaryValue {
ScalarValue value = 2;
}
+message IntervalMonthDayNanoValue {
+ int32 months = 1;
+ int32 days = 2;
+ int64 nanos = 3;
+}
+
message ScalarValue{
oneof value {
+ // Null value of any type (type is encoded)
+ PrimitiveScalarType null_value = 19;
Review Comment:
I really dislike PrimitiveScalarType and have plans to remove it
##########
datafusion/proto/proto/datafusion.proto:
##########
@@ -733,9 +733,18 @@ message ScalarDictionaryValue {
ScalarValue value = 2;
}
+message IntervalMonthDayNanoValue {
+ int32 months = 1;
+ int32 days = 2;
+ int64 nanos = 3;
+}
+
message ScalarValue{
oneof value {
+ // Null value of any type (type is encoded)
+ PrimitiveScalarType null_value = 19;
Review Comment:
I really dislike PrimitiveScalarType and hope to remove it eventually
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
